Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pinterest pp & tos #1495

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

afisher3578
Copy link
Contributor

No description provided.

Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex for this correction! I've updated the validUntil date, which didn't seem right, and I'd be happy to talk to you about it if you'd like.

@clementbiron clementbiron merged commit c446f05 into OpenTermsArchive:main Jun 19, 2024
3 checks passed
@afisher3578
Copy link
Contributor Author

afisher3578 commented Jun 19, 2024

Hey @clementbiron thank you for updating the validUntildate. I took the date that was referenced in the issues for all of my latest pull requests so they are all probably wrong. Where did you find the correct date so I know where to look in the future?

@clementbiron
Copy link
Member

Hi Alex,

You're right to ask and I should have explained in my first comment, sorry. It shows us once again that our documentation on this subject is not quite complete and that it deserves to be improved.

In any case, I retrieved the date of valitUntil by doing the following:

  1. first I go to the open issue and position myself on the last comment from OTA-Bot

  2. on the date of this comment I right-click "inspect" (on this case, the date is not quite precise, it's "last month")

image
  1. I copy the value of the datetime attribute from the <relative-time> element
image

I hope this helps and don't hesitate to ask for clarification !

@afisher3578
Copy link
Contributor Author

@clementbiron Thank you for the detailed explanation, that clears up my question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants