Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure configuration to prevent conflicts with other OTA applications #1071

Merged
merged 11 commits into from
May 22, 2024

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented May 13, 2024

No description provided.

@Ndpnt Ndpnt requested a review from clementbiron May 13, 2024 15:11
SENDINBLUE_API_KEY='xkeysib-3f51c…'
SMTP_PASSWORD='password'
GITHUB_TOKEN=ghp_XXXXXXXXX
OTA_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to avoid using the abbreviation OTA.

Suggested change
OTA_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…'
OPENTERMSARCHIVE_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…'

src/collection-api/routes/docs.test.js Show resolved Hide resolved
@Ndpnt Ndpnt force-pushed the restructure-configuration branch 6 times, most recently from 2f49aa6 to b09f26e Compare May 14, 2024 09:06
@Ndpnt Ndpnt force-pushed the restructure-configuration branch 2 times, most recently from 672ec3f to 4cdc39a Compare May 14, 2024 12:22
CHANGELOG.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/archivist/fetcher/index.test.js Outdated Show resolved Hide resolved
@Ndpnt Ndpnt force-pushed the restructure-configuration branch from 4cdc39a to 68a6bbd Compare May 22, 2024 08:46
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Ndpnt Ndpnt force-pushed the restructure-configuration branch from 68a6bbd to ec185c0 Compare May 22, 2024 09:28
@Ndpnt Ndpnt merged commit 79b0a5b into main May 22, 2024
9 checks passed
@Ndpnt Ndpnt deleted the restructure-configuration branch May 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants