-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure configuration to prevent conflicts with other OTA applications #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SENDINBLUE_API_KEY='xkeysib-3f51c…' | ||
SMTP_PASSWORD='password' | ||
GITHUB_TOKEN=ghp_XXXXXXXXX | ||
OTA_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to avoid using the abbreviation OTA
.
Suggested change
OTA_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…' | |
OPENTERMSARCHIVE_ENGINE_SENDINBLUE_API_KEY='xkeysib-3f51c…' |
Ndpnt
force-pushed
the
restructure-configuration
branch
6 times, most recently
from
May 14, 2024 09:06
2f49aa6
to
b09f26e
Compare
clementbiron
approved these changes
May 14, 2024
Ndpnt
force-pushed
the
restructure-configuration
branch
2 times, most recently
from
May 14, 2024 12:22
672ec3f
to
4cdc39a
Compare
MattiSG
reviewed
May 16, 2024
Ndpnt
force-pushed
the
restructure-configuration
branch
from
May 22, 2024 08:46
4cdc39a
to
68a6bbd
Compare
MattiSG
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Default configurations have been removed to ensure that users specify them in their configuration files, ensuring they are made available to the infrastructure deployment code.
Ndpnt
force-pushed
the
restructure-configuration
branch
from
May 22, 2024 09:28
68a6bbd
to
ec185c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.