Fix config loading #976
Merged
Fix config loading #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndpnt
force-pushed
the
fix-config-loading
branch
from
2ca7b4d
to
bdf6286
Compare
Ndpnt
force-pushed
the
fix-config-loading
branch
from
bdf6286
to
038c24f
Compare
Ndpnt
force-pushed
the
fix-config-loading
branch
from
038c24f
to
8bba399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As now this module is published as @opentermsarchive/engine package, we aim to reverse the way we deploy instances. Instances will use declared engine in dependencies.
To do this, we also need to move the instances configurations out of the engine and so the way the configurations are loaded needs to be updated. That's what this PR does.