Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of .NET Standard2.0 and .NET Core2.0. #235

Closed
daisukenishino opened this issue Apr 19, 2017 · 3 comments
Closed

Added support of .NET Standard2.0 and .NET Core2.0. #235

daisukenishino opened this issue Apr 19, 2017 · 3 comments
Labels
enhancement New feature or request

Comments

@daisukenishino
Copy link
Contributor

daisukenishino commented Apr 19, 2017

Requirement

In the future, to support such as .NET Core, I try to separate the classes that operate on ".NET Standard" in the "Public" namespace into the "Standard" namespace.

  • Migrate library of Public namespace to Standard namespace.
  • Change it to use the library migrated from the Public namespace to the Standard namespace.
@daisukenishino daisukenishino added the enhancement New feature or request label Apr 19, 2017
@daisukenishino daisukenishino added this to the Release of 02-x0 version milestone Apr 19, 2017
@daisukenishino daisukenishino modified the milestones: Release of 02-x0 version, Release of 02-10 version Aug 9, 2017
@daisukenishino daisukenishino modified the milestones: Release of 02-20 version, Release of 02-x0 version Dec 20, 2017
@daisukenishino2
Copy link
Member

daisukenishino2 commented Mar 30, 2018

Perform of verification

There are some trajectory corrections, but we started verification.

By proceeding with the verification it will be closer to the final answer.

@daisukenishino2
Copy link
Member

daisukenishino2 commented Mar 30, 2018

Result of verification

Currently, It have completed migration of Public namespace and Framework and Business namespace. Though the #IF-DEF directive will be needed in the work, the code base can be nearly equal state and I think that netstandard assembly can be generate by build without duplicating the source code.

Obtain the following diff if you want to confirm.

As a result, this netstandard assembly can added to the same NuGet package as target="lib\netstandard".

And there is a attention matter that the features provided by the netstandard assembly is a subset of net assembly, it can not provide complete functions to net program. Therefore net program will continue to use the net assembly instead of netstandard assembly. On the other hand, netcore and mono program use netstandard assembly. But fortunately, this behavior is the default UX when using the NuGet package created in the above procedure.

In addition, since the Business namespace is a customizable layer, I think that it should be implemented with netstandard and mono instead of netstandard. And, whether the libraries of netcore and mono should supplement missing functions, location of the supplementary layers should be considered at beforehand.

※ For above reasons the title of this issue has been fixed. Splitting namespace does not occur. And, support of netcore will also proceed at the same time.

changed the title from ”Separate classes that operate on .NET Standard in the Public namespace into the Standard namespace.” to ”Support the.NET Standard2.0 and .NET Core2.0 .”.

@daisukenishino2
Copy link
Member

daisukenishino2 commented Mar 30, 2018

Considerations related the test

The targetFramework of the first test runner should be netcore, and should be implemented as batch, MVC, Web API, UWP etc. therefore there is needs to add these netcore samples to Samples4NetCore folder in the OpenTouryo and OpenTouryoTemplate repository.

It may be good to use NUnit according to the following information.
https://docs.microsoft.com/ja-jp/dotnet/core/testing/unit-testing-with-nunit

As this result, will be able to get the netcore development know-how such as batch and MVC.

Future prospects

  • Add netcore samples to Samples4NetCore folder in the OpenTouryo and OpenTouryoTemplate repository.
  • And based on the above netcore samples, create a new MultiPurposeMobileBackend repository.
  • MultiPurposeMobileBackend repository contains Mobile frontend and backend applications.

@daisukenishino daisukenishino changed the title Separate classes that operate on .NET Standard in the Public namespace into the Standard namespace. Migrate to .NET Standard. Mar 30, 2018
daisukenishino2 added a commit that referenced this issue Apr 2, 2018
daisukenishino2 added a commit that referenced this issue Apr 2, 2018
daisukenishino2 added a commit that referenced this issue Apr 2, 2018
daisukenishino2 added a commit that referenced this issue Apr 2, 2018
daisukenishino2 added a commit that referenced this issue Apr 2, 2018
daisukenishino2 added a commit that referenced this issue Apr 3, 2018
daisukenishino2 added a commit that referenced this issue Apr 3, 2018
daisukenishino2 added a commit that referenced this issue Apr 3, 2018
daisukenishino2 added a commit that referenced this issue Apr 4, 2018
@daisukenishino2 daisukenishino2 changed the title Migrate to .NET Standard. Support the.NET Standard2.0 and .NET Core2.0 . Apr 5, 2018
daisukenishino2 added a commit that referenced this issue Apr 5, 2018
daisukenishino2 added a commit that referenced this issue Apr 9, 2018
daisukenishino2 added a commit that referenced this issue Apr 9, 2018
daisukenishino2 added a commit that referenced this issue Jul 19, 2018
@daisukenishino daisukenishino changed the title Support the.NET Standard2.0 and .NET Core2.0 . Support the.NET Standard2.0 and .NET Core2.0. Sep 19, 2018
@daisukenishino2 daisukenishino2 changed the title Support the.NET Standard2.0 and .NET Core2.0. Added support of .NET Standard2.0 and .NET Core2.0. Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants