Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove status reports and date functions #1080

Merged

Conversation

TinCanTech
Copy link
Collaborator

@TinCanTech TinCanTech commented Feb 16, 2024

Remove Status Reports:

  • show-expire: Shows expration status
  • show-revoke: Shows revoked status
  • show-renew: Shows renew status

Removed Unused functions:

  • ssl_cert_not_before_date()
  • ssl_cert_not_after_date()
  • iso_8601_cert_startdate()
  • iso_8601_cert_enddate()
  • iso_8601_timestamp_to_seconds()
  • days_to_timestamp_s()
  • cert_date_to_timestamp_s()
  • db_date_to_iso_8601_date()
  • cert_date_to_iso_8601_date()
  • read_db()

This change shows how Status Reports code can be removed, in a single step.

@TinCanTech TinCanTech self-assigned this Feb 16, 2024
@TinCanTech TinCanTech added the development Possible changes label Feb 17, 2024
@TinCanTech TinCanTech force-pushed the REMOVE-status-reports-and-date branch 2 times, most recently from 4846263 to d5af385 Compare February 17, 2024 00:48
Remove Status Reports:
- show-expire: Shows expration status
- show-revoke: Shows revoked status
- show-renew: Shows renew status

Removed Unused functions:
- ssl_cert_not_before_date()
- ssl_cert_not_after_date()
- iso_8601_cert_startdate()
- iso_8601_cert_enddate()
- iso_8601_timestamp_to_seconds()
- days_to_timestamp_s()
- cert_date_to_timestamp_s()
- db_date_to_iso_8601_date()
- cert_date_to_iso_8601_date()
- read_db()

Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Copy link
Collaborator Author

Status reports are now re-integrated via easyrsa-tools.lib.

CI test above show correct operation.

@TinCanTech
Copy link
Collaborator Author

Pros: Removes almost one thousand LOC from easyrsa.
Cons: None.

@TinCanTech TinCanTech added this to the v3.2.0 milestone Mar 6, 2024
@TinCanTech TinCanTech added Major Changes Changes between Major 3.X version numbers - X is Major ChangeLog Item Version 3.2.0-Release and removed initial-approval development Possible changes labels Mar 6, 2024
@TinCanTech TinCanTech merged commit 774ada8 into OpenVPN:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangeLog Item improvement Major Changes Changes between Major 3.X version numbers - X is Major Version 3.2.0-Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant