-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple maintenance improvements #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channels are active at libera.chat IRC network instead
The old license file has an extra newline. Downloaded from: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
Rebased to improve commit messages, split them up for easier review, and gpg sign the commits. |
TinCanTech
previously approved these changes
Mar 15, 2022
TinCanTech
dismissed
their stale review
March 15, 2022 01:19
This approval is too broad, removing (My apologies)
TinCanTech
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must get approval for the IRC network change but the rest looks good, thanks!
TinCanTech
added
initial-approval
Full-Approval
Merge is imminent
and removed
initial-approval
labels
Mar 15, 2022
TinCanTech
approved these changes
Mar 22, 2022
TinCanTech
added a commit
that referenced
this pull request
Mar 22, 2022
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the mention of channels on freenode is the most important part.