Replace non-POSIX mktemp with POSIX mkdir and mv #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mktemp was used to create temp-files but it is not POSIX and the version shipped for Windows has known bugs. Replace mktemp with atomic directory and file creation using mkdir and mv, both of which are atomic. The temporary directory "session" directory is created using mkdir with a 32bit random number for the name. eg: /tmp/easyrsa-temp/b01dface The temporary file is created by moving another file into the place of the temp-file, with a 32bit random number for the name. eg: /tmp/easyrsa-temp/b01dface/c01dface Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
added
enhancement
Applicable to v3.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mktemp was used to create temp-files but it is not POSIX and
the version shipped for Windows has known bugs.
Replace mktemp with atomic directory and file creation using mkdir
and mv, both of which are atomic.
The temporary directory "session" directory is created using mkdir
with a 32bit random number for the name.
eg: /tmp/easyrsa-temp/b01dface
The temporary file is created by moving another file into the place
of the temp-file, with a 32bit random number for the name.
eg: /tmp/easyrsa-temp/b01dface/c01dface
Signed-off-by: Richard T Bonhomme tincantech@protonmail.com