Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce command 'set-pass' #756

Merged
merged 2 commits into from Nov 13, 2022
Merged

Conversation

TinCanTech
Copy link
Collaborator

Current 'set-X-pass' commands do not support Edwards Curve cryptography.

Replace all 'set-X-pass' commands with single 'set-pass' command.

The new EasyRSA 'set-pass' command uses OpenSSL command 'pkey' to manipulate private keys. OpenSSL 'pkey' command supports all EasyRSA cryptography.

Signed-off-by: Richard T Bonhomme tincantech@protonmail.com

@TinCanTech TinCanTech self-assigned this Nov 6, 2022
@TinCanTech TinCanTech added enhancement BUG-FIX Major Changes Changes between Major 3.X version numbers - X is Major Applicable to v3.0.x PRs welcome Version 3.1.x labels Nov 6, 2022
@TinCanTech TinCanTech added this to the v3.1.2 - Probably milestone Nov 6, 2022
@TinCanTech
Copy link
Collaborator Author

Major portion of #755

TinCanTech added a commit to TinCanTech/easy-rsa that referenced this pull request Nov 6, 2022
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Copy link
Collaborator Author

Note: There is no unit test for set-pass or its predecessors. Therefore, I have tested this manually and thoroughly.

@TinCanTech TinCanTech linked an issue Nov 7, 2022 that may be closed by this pull request
Replace all 'set-X-pass' commands with single 'set-pass' command.

The new EasyRSA 'set-pass' command uses OpenSSL command 'pkey' to manipulate
private keys.  OpenSSL 'pkey' command supports all EasyRSA cryptography.

Retain compatibility with old commands.

Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Copy link
Collaborator Author

force-push to retain old commands.

Closes: OpenVPN#765

Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech TinCanTech linked an issue Nov 11, 2022 that may be closed by this pull request
@TinCanTech

This comment was marked as outdated.

@TinCanTech TinCanTech merged commit 824849b into OpenVPN:master Nov 13, 2022
@TinCanTech TinCanTech deleted the fix-set_pass branch January 3, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applicable to v3.0.x PRs welcome BUG-FIX ChangeLog Item enhancement Major Changes Changes between Major 3.X version numbers - X is Major Version 3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set-X-pass should not use SSL option -nodes/-noenc set_pass() does not support Edwards Curves
1 participant