fixed_cert_dates(): Remove subshell #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed_cert_dates(): Replace capturing subshell-output by setting variables via safe_set_var(). Add error detection for 'date' usage. Wrap long lines. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
new-date-functions
branch
from
84022f0
to
7492097
Compare
This only effects status_expire(), show-expire. Add error detection for 'date' usage. Wrap long lines. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
new-date-functions
branch
from
4b61dcd
to
c83a26d
Compare
safe_set_var(): Show offending input value in error output Standardise similar functions: * ssl_cert_serial() * ssl_cert_not_before_date() * ssl_cert_not_after_date Wrap more long lines. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed_cert_dates(): Replace capturing subshell-output by setting variables via safe_set_var()
Wrap long lines.
Signed-off-by: Richard T Bonhomme tincantech@protonmail.com