set_var and force_set_var: Guard against invalid user input #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinCanTech
force-pushed
the
force_set_var-v2
branch
from
53048e1
to
c6f405c
Compare
nix.sh/win.sh/busybox.sh never return error from unset when an invalid variable name 'a=b' is used with a value to set, eg. 'c'; This causes EasyRSA to execute: eval "export a=b=c". 'set_var EASYRSA_PKI=pki' results in $EASYRSA_PKI being set to 'pki=pki-', without error! Guard against this possible user error with 'case'. Minor improvements to other input checks. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
force_set_var-v2
branch
from
c6f405c
to
6edffac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix.sh/win.sh/busybox.sh never return error from unset when an invalid variable name 'a=b' is used with a value to set, eg. 'c'; This causes EasyRSA to execute:
eval "export a=b=c".
'set_var EASYRSA_PKI=pki' results in $EASYRSA_PKI being set to 'pki=pki-', without error!
Guard against this possible user error with 'case'.
Minor improvements to other input checks.