WIP: Add a new set of icons for connection states and notifications #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi,
On Thu, Mar 16, 2023 at 04:50:08PM -0700, Selva Nair wrote:
- In this version I've retained both old and new icons and added an option to switch. It defaults to "legacy icons" for now. Those who want to switch right away can do so by clicking a checkbox. Is this acceptable?
I like that flexibility. Maybe we can have a poll for 2.7 then which
icon set people like more, and drop the other one. Or just keep 'em.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany ***@***.***
|
- The notification icons and status window and menu item states can now optionally use icons that resemble the main application icon. New icons for five states (disconnected, connecting, connected, connected_with_errors, idle_error) are loaded though we currently use only the first three. TODO: Indicate connected-with-errors state using the corresponding icon, and improve how states are reported when there are multiple connections with conflicting states. Signed-off-by: Selva Nair <selva.nair@gmail.com>
|
Changes:
Some issues still remain: the orange dots in "connecting.ico" are drawn with white "stroke" and orange "fill". Just setting the background to transparent does not remove those white lines, and they look odd when displayed in dark background. Could be changed by editing the svg's but I'm not going to get into graphic design. If anyone wants to edit these, the svgs from #595 with my changes are in the zip file below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP (icon files need some fixes), but I would appreciate feedback on some questions I have:
Knowing how hard such changes could be for some of users I interact with, I can empathize with admins who may complain.
The new icons are as discussed in this thread: #595