Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphepg movement algorithm #334

Merged
merged 6 commits into from
Nov 27, 2018

Conversation

SimonCapewell
Copy link
Contributor

More graph EPG fixes:

  1. Fix reported crash when not using cached EIT data
  2. Removes an unintentional full screen invalidate when navigating within a page of the EPG when service numbers are shown. getTextBoundarySize has a side effect of invalidating the instance it's using to parent a dummy label used to calculate the text size. A better solution would be to expose a C++ method somewhere similar to eLabel::calculateSize, however I've not found any suitable guidance on how to get set up to develop with the e2 c++ code.

There's still a few more improvements to load time that could be made:
Occasional double calls to buildGraphEntry when loading, seems to be after changing channel
Another 100ms can be shaved off the load time of the EPG by caching the graphics. Yes, they're flagged to be cached in the C++ layer, but caching in static variables in EPGList is quicker on repeated opening.

@RobvanderDoes RobvanderDoes merged commit 293b069 into OpenViX:Dev Nov 27, 2018
@SimonCapewell SimonCapewell deleted the graphepg-movement-algorithm branch March 2, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants