Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More graph EPG fixes:
getTextBoundarySize
has a side effect of invalidating the instance it's using to parent a dummy label used to calculate the text size. A better solution would be to expose a C++ method somewhere similar toeLabel::calculateSize
, however I've not found any suitable guidance on how to get set up to develop with the e2 c++ code.There's still a few more improvements to load time that could be made:
Occasional double calls to
buildGraphEntry
when loading, seems to be after changing channelAnother 100ms can be shaved off the load time of the EPG by caching the graphics. Yes, they're flagged to be cached in the C++ layer, but caching in static variables in
EPGList
is quicker on repeated opening.