Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback/no_make_active #134

Merged
merged 2 commits into from
Sep 30, 2023
Merged

fallback/no_make_active #134

merged 2 commits into from
Sep 30, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 30, 2023

let the intent service handle this, unittests in core uncovered duplicate messages this commit is fixing

let the intent service handle this, unittests in core uncovered duplicate messages this commit is fixing
@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1da89e3) 57.67% compared to head (c0872b6) 57.75%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #134      +/-   ##
==========================================
+ Coverage   57.67%   57.75%   +0.07%     
==========================================
  Files          34       34              
  Lines        3301     3319      +18     
==========================================
+ Hits         1904     1917      +13     
- Misses       1397     1402       +5     
Files Coverage Δ
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/fallback.py 62.14% <75.00%> (+0.92%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

let the intent service handle this, unittests in core uncovered duplicate messages this commit is fixing
@JarbasAl JarbasAl merged commit bc265e9 into dev Sep 30, 2023
9 checks passed
@JarbasAl JarbasAl deleted the fallback/no_make_active branch September 30, 2023 15:18
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant