Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/move_from_utils #153

Merged
merged 4 commits into from
Dec 28, 2023
Merged

refactor/move_from_utils #153

merged 4 commits into from
Dec 28, 2023

Conversation

JarbasAl
Copy link
Member

OpenVoiceOS/ovos-utils#205

code from ovos-utils that fits better in this package

moved in preparation for ovos-utils 0.1.0

@JarbasAl JarbasAl added refactor code improvements with no functional changes packaging labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (4f65ac5) 60.23% compared to head (2c7712d) 59.31%.
Report is 20 commits behind head on dev.

Files Patch % Lines
ovos_workshop/intents.py 71.78% 57 Missing ⚠️
ovos_workshop/skills/ovos.py 30.00% 42 Missing ⚠️
ovos_workshop/skills/api.py 0.00% 35 Missing ⚠️
ovos_workshop/permissions.py 14.28% 18 Missing ⚠️
ovos_workshop/settings.py 40.90% 13 Missing ⚠️
ovos_workshop/skills/fallback.py 87.50% 2 Missing ⚠️
ovos_workshop/skills/intent_provider.py 0.00% 1 Missing ⚠️
ovos_workshop/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #153      +/-   ##
==========================================
- Coverage   60.23%   59.31%   -0.93%     
==========================================
  Files          34       36       +2     
  Lines        3347     3667     +320     
==========================================
+ Hits         2016     2175     +159     
- Misses       1331     1492     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 308ff2d into dev Dec 28, 2023
8 of 9 checks passed
@JarbasAl JarbasAl deleted the refactor/utils branch December 28, 2023 19:59
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant