Add ovos-utils 0.0.X dependency compat. #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #449 +/- ##
=======================================
Coverage 66.70% 66.70%
=======================================
Files 15 15
Lines 2607 2607
=======================================
Hits 1739 1739
Misses 868 868
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JarbasAl
requested changes
May 4, 2024
|
continued here OpenVoiceOS/OVOS-workshop#200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ovos-workshop dependency to allow ovos-utils 0.0.X compat.
https://github.com/NeonGeckoCom/NeonCore/actions/runs/8886985863/job/24401444645?pr=641
According to PyCharm, no import or other errors are caused by this change and tests are passing, but I am not sure if there is any other context to this version update other than OCP and CommonQA intent service (optional) improvements.
This alpha dependency was added in #442 with the (optional) OCP intent service