Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/skill plugins #9

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Feat/skill plugins #9

merged 2 commits into from
Feb 3, 2022

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 3, 2021 •
edited
Loading

see https://github.com/OpenVoiceOS/ovos-plugin-skill-hello-world/blob/dev/setup.py

allows skills to be packaged by distros / be installed with pip

retains full backwards compatibility:

  • skills can run in mycroft-core as usual
  • if a skill is loaded from folder the corresponding plugin is replaced by it

based on NeonJarbas/NeonCore@0735033

related issues:

@JarbasAl JarbasAl added the enhancement New feature or request label Nov 3, 2021
@JarbasAl JarbasAl marked this pull request as ready for review November 3, 2021 19:38
@JarbasAl JarbasAl mentioned this pull request Nov 3, 2021
Merged
This was referenced Nov 3, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JarbasAl
Copy link
Member Author

JarbasAl commented Nov 4, 2021 •
edited
Loading

(this comment became #11)

NeonDaniel
NeonDaniel reviewed Nov 4, 2021
View reviewed changes
mycroft/skills/mycroft_skill/mycroft_skill.py Outdated Show resolved Hide resolved
mycroft/skills/mycroft_skill/mycroft_skill.py Outdated Show resolved Hide resolved
mycroft/skills/mycroft_skill/mycroft_skill.py Outdated Show resolved Hide resolved
@JarbasAl JarbasAl mentioned this pull request Nov 4, 2021
Merged
@JarbasAl JarbasAl mentioned this pull request Nov 10, 2021
Closed
@JarbasAl
Copy link
Member Author

JarbasAl commented Nov 10, 2021 •
edited
Loading

after some more review, i missed converse and the bus api while porting NeonJarbas/NeonCore@0735033

marking as draft until i get the missing pieces

@JarbasAl JarbasAl marked this pull request as draft November 10, 2021 15:16
@JarbasAl JarbasAl added the neon-core ported from neon-core label Nov 10, 2021
@JarbasAl JarbasAl marked this pull request as ready for review November 10, 2021 15:38
This was referenced Nov 14, 2021
Closed
Closed
@JarbasAl JarbasAl marked this pull request as draft November 15, 2021 20:05
@JarbasAl JarbasAl mentioned this pull request Nov 15, 2021
Merged
@JarbasAl
Copy link
Member Author

depends on/includes #27

@JarbasAl JarbasAl force-pushed the feat/skill_plugins branch 2 times, most recently from 1080d22 to 12e62a0 Compare November 18, 2021 13:20
@NeonJarbas NeonJarbas mentioned this pull request Nov 18, 2021
Merged
JarbasAl added a commit that referenced this pull request Nov 26, 2021
@JarbasAl
feat/skill plugins (#9)
35a8e4c
JarbasAl added a commit that referenced this pull request Feb 1, 2022
@JarbasAl
feat/skill plugins (#9)
cb03cf6
JarbasAl added a commit that referenced this pull request Feb 1, 2022
@JarbasAl
feat/skill plugins (#9)
328053c
@JarbasAl JarbasAl marked this pull request as ready for review February 2, 2022 20:17
NeonDaniel
NeonDaniel reviewed Feb 2, 2022
View reviewed changes
mycroft/skills/__main__.py Outdated Show resolved Hide resolved
mycroft/skills/skill_manager.py Outdated Show resolved Hide resolved
mycroft/skills/skill_manager.py Outdated Show resolved Hide resolved
NeonDaniel
NeonDaniel approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked with some brief testing against NeonCore

@JarbasAl JarbasAl merged commit 0e3e2b8 into dev Feb 3, 2022
@JarbasAl JarbasAl deleted the feat/skill_plugins branch February 3, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

@ChanceNCounter ChanceNCounter Awaiting requested review from ChanceNCounter

Assignees
No one assigned
Labels
enhancement New feature or request neon-core ported from neon-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JarbasAl @ChanceNCounter @NeonDaniel