-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mt/polish #164
mt/polish #164
Conversation
WalkthroughThe changes introduce a new JSON file that contains Polish translations for various elements of the Open Voice OS installation process. This includes translations for user interface prompts, feature descriptions, and telemetry consent messages, aimed at enhancing the accessibility of the installation experience for Polish-speaking users. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Installer
participant System
User->>Installer: Start Installation
Installer->>System: Load Polish Translations
System-->>Installer: Provide Translations
Installer->>User: Display Installation Prompts in Polish
User->>Installer: Provide Input
Installer->>System: Process Input
System-->>Installer: Confirm Choices
Installer->>User: Show Summary and Options
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
translations/pl-pl/strings.json (1)
2-7
: Maintain consistency in button label capitalization.The translations for button labels look good, but there's a minor inconsistency in capitalization:
- "ok_button" and "yes_button" use sentence case
- "no_button" uses all uppercase
- "back_button" uses title case
Consider using consistent capitalization across all button labels for a uniform appearance.
Suggested change for line 5:
- "no_button": "NIE", + "no_button": "Nie",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- translations/pl-pl/strings.json (1 hunks)
🔇 Additional comments (11)
translations/pl-pl/strings.json (11)
8-11
: LGTM: Channels section translation is accurate and well-formatted.The translation for the channels selection screen is accurate and maintains the original meaning. The multi-line formatting is correct, and the description of the available channels (stable and development) is clear.
12-15
: LGTM: System detection section is well-translated with preserved placeholders.The translation for the system detection screen is accurate and maintains all the necessary placeholders for system information. The formatting is correct, and the content is clear.
16-22
: LGTM: Features section is accurately translated and well-structured.The translation for the features selection screen is accurate and maintains the original meaning. The descriptions for GUI and skills features are clear and informative. The formatting is correct, and there are no issues with inconsistencies.
23-26
: LGTM: Installation completion section is well-translated with preserved examples.The translation for the installation completion screen is accurate and maintains the original meaning. The example voice commands are appropriately translated, and the placeholder for the config file path is preserved. The content is informative and encouraging for new users.
27-30
: LGTM: Installation methods section is accurately translated.The translation for the installation methods selection screen is accurate and maintains the original meaning. The descriptions of container-based and Python virtual environment installation options are clear and informative. The formatting is correct, and there are no issues with inconsistencies.
31-34
: LGTM: Installation profiles section is well-translated and informative.The translation for the installation profiles selection screen is accurate and maintains the original meaning. The descriptions of the four different profile options (Open Voice OS Master, HiveMind Satellite, HiveMind Listener, and Server) are clear and informative. The formatting is correct, and the content effectively communicates the unique features of each profile.
35-45
: LGTM: HiveMind Satellite configuration section is accurately translated.The translation for the HiveMind Satellite configuration screens is accurate and maintains the original meaning. The titles and content for the four different steps of the configuration process are clear and concise. The instructions for entering the host address, port, key, and password are well-translated and easy to understand.
46-49
: LGTM: Installation summary section is well-translated with preserved placeholders.The translation for the installation summary screen is accurate and maintains the original meaning. All placeholders for installation choices (e.g., $METHOD, $CHANNEL, $PROFILE) are correctly preserved. The content provides a clear and concise overview of the user's selections during the installation process.
50-53
: LGTM: Telemetry consent section is accurately translated and informative.The translation for the telemetry consent screen is accurate and maintains the original meaning. The detailed explanation of telemetry data collection and its purpose is well-translated, addressing potential privacy concerns. The URL for more information is correctly preserved, and the content effectively communicates the importance and anonymity of the collected data.
54-66
: LGTM: Tuning, uninstallation, and welcome sections are well-translated and informative.The translations for the tuning options, uninstallation process, and welcome screen are accurate and maintain the original meaning. Each section provides clear and detailed explanations:
- The tuning section explains the benefits of optimizing for Raspberry Pi.
- The uninstallation section clearly outlines which components will not be removed and why.
- The welcome section provides an enthusiastic and informative introduction to Open Voice OS.
The formatting is correct across all sections, and the content effectively communicates the necessary information to users.
1-66
: Overall: Excellent translation quality with minor suggestions for improvement.The Polish translation file for the Open Voice OS installer is of high quality and accurately conveys the original meaning across all sections. The JSON structure is correct, and placeholders are properly preserved throughout the file. The translations are informative, clear, and maintain a consistent tone.
There's only one minor suggestion for improvement:
- Consider standardizing the capitalization of button labels in the "misc.sh" section for consistency.
Great job on providing a comprehensive and well-structured translation that will enhance the user experience for Polish-speaking users of Open Voice OS!
"content": "Decydując się na udostępnienie nam danych telemetrycznych, odgrywasz kluczową rolę w dostarczaniu cennych, anonimowych informacji, które pozwalają nam lepiej zrozumieć doświadczenia użytkowników i poprawić wydajność naszego oprogramowania.\n\nTwoje dane telemetryczne zawierają istotne informacje na temat tego, jak oprogramowanie działa w rzeczywistych scenariuszach. Dane te są gromadzone anonimowo, priorytetowo traktując Twoją prywatność i poufność.\n\nZgromadzone informacje pomagają nam identyfikować potencjalne problemy, optymalizować funkcje i zapewniać płynniejsze, bardziej wydajne środowisko użytkownika dla wszystkich.\n\nAby uzyskać więcej informacji na temat zebranych danych, odwiedź stronę: https://github.com/OpenVoiceOS/ovos-installer/tree/main/docs/telemetry.md\n\nTo gromadzenie danych będzie miało miejsce tylko podczas procesu instalacji.\n\nCzy zgadzasz się udostępniać nam anonimowe dane?" | ||
}, | ||
"tuning.sh": { | ||
"title": "Instalacja Open Voice OS - Strojenie", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the English "Tuning" instead of "Strojenie" would be a better word here
initial machine translation
See review request for strings.json on GitLocalize
Summary by CodeRabbit