refactor/ocp_utils #216
Merged
refactor/ocp_utils #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonJarbas
force-pushed
the
refactor/ocp_models
branch
from
745059b
to
fa712e9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #216 +/- ##
==========================================
+ Coverage 39.30% 41.54% +2.23%
==========================================
Files 31 31
Lines 2801 3004 +203
==========================================
+ Hits 1101 1248 +147
- Misses 1700 1756 +56 ☔ View full report in Codecov by Sentry. |
move the MediaType and Playlist model to utils so they can be reused across ovos modules skills will then be able to return these objects directly in the ocp decorators
NeonJarbas
force-pushed
the
refactor/ocp_models
branch
from
65fb862
to
451432c
Compare
NeonJarbas
commented
Jan 8, 2024
| np = [m3, m, m2] | ||
| assert p == np | ||
| assert np == p | ||
| assert p == p.entries |
There was a problem hiding this comment.
TODO convert these into unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor/ocp_models
move the MediaType and Playlist model to utils so they can be reused across ovos modules
skills will then be able to return these objects directly in the ocp decorators