Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network building enhancements #580

Merged
merged 9 commits into from
Jul 15, 2020
Merged

Network building enhancements #580

merged 9 commits into from
Jul 15, 2020

Conversation

LRossman
Copy link
Collaborator

@LRossman LRossman commented Feb 4, 2020

See ReleaseNotes2_3.md.

@eladsal
Copy link
Member

eladsal commented Feb 9, 2020

@LRossman regarding backward comparability, is it right to say that the only thing that breaks is the assumption that if ENopen return's 0 the network data passes all the tests?

@LRossman
Copy link
Collaborator Author

LRossman commented Feb 9, 2020

@eladsal the first commit (80f9acf) that passed the CI tests contained only the updates that allowed ENopen to successfully process a partial network and to set a curve's type so that my Lazarus GUI project could move forward. These changes had no effect on the solver's results.

Then I got greedy and tried to incorporate some changes to the hydraulic solver that would improve its robustness by replacing the status checking it does during the Newton iterations with continuous penalty functions. These actually work quite nicely but as with all changes to the solver code they can produce results that are slightly different from the benchmark test results (e.g., a flow of 30.29 gpm compared with 30.30) thus causing the CI tests to fail.

Since I don't want to re-do the benchmark results at this time, I will revert dev_2.3 back to its 80f9acf state and fork another branch from it where I will continue my efforts to improve the solver.

@LRossman
Copy link
Collaborator Author

Finally getting around to merging this update into dev. It addresses issues #575, #576, and #579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants