-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network building enhancements #580
Conversation
@LRossman regarding backward comparability, is it right to say that the only thing that breaks is the assumption that if |
@eladsal the first commit ( Then I got greedy and tried to incorporate some changes to the hydraulic solver that would improve its robustness by replacing the status checking it does during the Newton iterations with continuous penalty functions. These actually work quite nicely but as with all changes to the solver code they can produce results that are slightly different from the benchmark test results (e.g., a flow of 30.29 gpm compared with 30.30) thus causing the CI tests to fail. Since I don't want to re-do the benchmark results at this time, I will revert |
Addresses issue #597.
See ReleaseNotes2_3.md.