refactor(csrrw): rewrite csr read/write using switch-case instead of multiple if-else. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewPaulWalker
added a commit
to NewPaulWalker/ready-to-run
that referenced
this pull request
Oct 11, 2024
* NEMU commit: OpenXiangShan/NEMU#573 * NEMU configs: * riscv64-xs-ref_defconfig * riscv64-dual-xs-ref_defconfig Including: * refactor(csrrw): rewrite csr read/write using switch-case instead of multiple if-else.
NewPaulWalker
added a commit
to NewPaulWalker/XiangShan
that referenced
this pull request
Oct 11, 2024
* NEMU commit: OpenXiangShan/NEMU#573 * NEMU configs: * riscv64-xs-ref_defconfig * riscv64-dual-xs-ref_defconfig Including: * refactor(csrrw): rewrite csr read/write using switch-case instead of multiple if-else.
NewPaulWalker
force-pushed
the
rewrite_csrrw
branch
from
dad0230
to
5a665bf
Compare
|
Using case range to handle a contiguous address range of CSR instead of if. |
NewPaulWalker
force-pushed
the
rewrite_csrrw
branch
from
5a665bf
to
5fa03ae
Compare
NewPaulWalker
force-pushed
the
rewrite_csrrw
branch
from
5fa03ae
to
ec089ee
Compare
NewPaulWalker
force-pushed
the
rewrite_csrrw
branch
from
ec089ee
to
32ab11c
Compare
huxuan0307
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
csr_readandcsr_writefunctions contained a lot of if-else-if structures, making maintenance difficult.I have rewritten these two functions using switch-case statements, including: