New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentralScene support #1125

Closed
wants to merge 1 commit into
base: Dev
from

Conversation

Projects
None yet
@robbiet480
Contributor

robbiet480 commented Feb 9, 2017

Continuing work from #1124, #993, but this time using the code base that @nechry suggested. I have personally tested this and it works with my HomeSeer HS-WD100+.

I'm looking for guidance on how to complete this. Right now, the values are being updated, but should I implement a new notification as well so that applications can just listen for that notification instead of having to collect possibly 9 values together?

Also, does anyone know which devices support Central Scene version 1 or Central Scene version 2? My switch seems to only support version 1.

@@ -63,6 +109,7 @@ CentralScene::CentralScene
CommandClass( _homeId, _nodeId ),
m_scenecount(0)
{
SetStaticRequest( StaticRequest_Values );

This comment has been minimized.

@stromnet

stromnet Feb 10, 2017

Contributor

indentation

This comment has been minimized.

@robbiet480

robbiet480 Feb 10, 2017

Contributor

Is there a code style guide for OZW?

This comment has been minimized.

@stromnet

stromnet Feb 10, 2017

Contributor

Not sure, just noticed that it missmatched the other lines around it :)

@stromnet

This comment has been minimized.

Contributor

stromnet commented Feb 10, 2017

Does this still have the static issue or was that solved somehow?

As for my ZRC-90, it claims to support Central Scene Command version 2

@robbiet480

This comment has been minimized.

Contributor

robbiet480 commented Feb 11, 2017

@stromnet Which static issue are you referring to, I didn't see a comment about it on previous PRs...

@stromnet

This comment has been minimized.

Contributor

stromnet commented Feb 11, 2017

Hm, the only specific comment I can find is this one:
#993 (comment)

And from my comment (#993 (comment)):

The same issue which was described above ("CentralScene: Not a StaticRequest") happened, but I disabled that check to just have it send the GET command anyway.. After that, ozw knew the number of scenes available, and the ValueIds was properly created, and reacted to.

Note sure about the exact details, or what even a "StaticRequest" is, so cannot give much more input than that.

@philk

This comment has been minimized.

philk commented Feb 14, 2017

This is working perfectly for me as well. These are the logs from my Homeseer WD100+ if it helps:

Double Down

2017-02-13 21:19:15.284 Detail, Node018,   Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x12, 0x05, 0x5b, 0x03, 0x20, 0x03, 0x02, 0x9e
2017-02-13 21:19:15.635 Info, Node018, Received Central Scene set from node 18: scene id=2 with key Attribute 3. Sending event notification.
2017-02-13 21:19:15.635 Detail, Node018, Refreshed Value: old value=2, new value=2, type=byte
2017-02-13 21:19:15.635 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:15.635 Detail, Node018, Refreshed Value: old value=23, new value=23, type=byte
2017-02-13 21:19:15.635 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:15.635 Detail, Node018, Notification: ValueChanged
2017-02-13 21:19:16.130 Detail, Node018, Notification: ValueChanged

Triple Down

2017-02-13 21:19:24.547 Detail, Node018,   Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x12, 0x05, 0x5b, 0x03, 0x21, 0x04, 0x02, 0x98
2017-02-13 21:19:24.547 Info, Node018, Received Central Scene set from node 18: scene id=2 with key Attribute 4. Sending event notification.
2017-02-13 21:19:24.547 Detail, Node018, Refreshed Value: old value=2, new value=2, type=byte
2017-02-13 21:19:24.547 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:24.548 Detail, Node018, Refreshed Value: old value=23, new value=24, type=byte
2017-02-13 21:19:24.548 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:24.548 Detail, Node018, Notification: ValueChanged
2017-02-13 21:19:24.551 Detail, Node018, Notification: ValueChanged

Double Up

2017-02-13 21:19:39.302 Detail, Node018,   Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x12, 0x05, 0x5b, 0x03, 0x22, 0x03, 0x01, 0x9f
2017-02-13 21:19:39.303 Info, Node018, Received Central Scene set from node 18: scene id=1 with key Attribute 3. Sending event notification.
2017-02-13 21:19:39.303 Detail, Node018, Refreshed Value: old value=2, new value=1, type=byte
2017-02-13 21:19:39.303 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:39.303 Detail, Node018, Refreshed Value: old value=24, new value=13, type=byte
2017-02-13 21:19:39.303 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:39.303 Detail, Node018, Notification: ValueChanged
2017-02-13 21:19:39.306 Detail, Node018, Notification: ValueChanged

Triple Up

2017-02-13 21:19:49.435 Detail, Node018,   Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x12, 0x05, 0x5b, 0x03, 0x23, 0x04, 0x01, 0x99
2017-02-13 21:19:49.435 Info, Node018, Received Central Scene set from node 18: scene id=1 with key Attribute 4. Sending event notification.
2017-02-13 21:19:49.435 Detail, Node018, Refreshed Value: old value=1, new value=1, type=byte
2017-02-13 21:19:49.435 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:49.435 Detail, Node018, Refreshed Value: old value=13, new value=14, type=byte
2017-02-13 21:19:49.435 Detail, Node018, Changes to this value are not verified
2017-02-13 21:19:49.436 Detail, Node018, Notification: ValueChanged
2017-02-13 21:19:49.441 Detail, Node018, Notification: ValueChanged
@Fishwaldo

This comment has been minimized.

Member

Fishwaldo commented Feb 17, 2017

Please Rebase this against the Dev branch, not master.

@areeeee

This comment has been minimized.

areeeee commented Feb 18, 2017

Is this something that will work with the aeotec wallmote quad as well or is this specific to the HomeSeer HS-WD100+?

@nechry

This comment has been minimized.

Member

nechry commented Feb 18, 2017

Fully work and tested with Aeotec ZW130
zw130_info
zw130_values

@willemstoker

This comment has been minimized.

willemstoker commented Mar 10, 2017

Hey guys, is this already released? I want a Aeotec ZW130 too

@timsamuelsson

This comment has been minimized.

timsamuelsson commented Mar 16, 2017

Any news on when this could be merged? :)

Thanks for all the good work!

@UltraSub

This comment has been minimized.

UltraSub commented Mar 18, 2017

Tested this with a Fibaro Keyfob FGKF-601 but still got no valueid assigned. But then again, maybe I did something wrong applying/recompiling it.
Should this work for this one too?

@nechry

This comment has been minimized.

Member

nechry commented Mar 18, 2017

I don't have the Fibaro keyfob, but my first guest is yes he should be working like other device using the CC CentralScene. Do you have other devices working with your setup? I mean with the CC CentralScene

@UltraSub

This comment has been minimized.

UltraSub commented Mar 18, 2017

Nope, this is my first one. No further experience. Noticed Openzwave had support for the Fibaro, purchased and then found out central scene support wasn't ready yet. Hope we can get this working soon :)

@nechry

This comment has been minimized.

Member

nechry commented Mar 18, 2017

Did you test base on Dev branch with this PR applied? If not it's normal the CC is not yet implemented

@UltraSub

This comment has been minimized.

UltraSub commented Mar 18, 2017

I only manually patched the two changed files in this PR into my local branch and recompiled. Will look into complete rebuild if I can find some time.

@nechry

This comment has been minimized.

Member

nechry commented Mar 18, 2017

@ZyberSE

This comment has been minimized.

ZyberSE commented Mar 22, 2017

I was under the impression CentralScene would be supported in the 1.6 release, but I can't find anything about it under the milestone. If I'm not mistaking it was there a while ago,wasn't it?

@UltraSub

This comment has been minimized.

UltraSub commented Mar 22, 2017

I switched to Dev branch, applied this PR, recompiled and excluded and included the Fibaro Keyfob. No dice. Still no ValueId assigned. Reverted to snapshot. Will test again later to see if I can reproduce or get it working.

@nechry

This comment has been minimized.

Member

nechry commented Mar 22, 2017

I don't have the Fibaro Keyfob to perform tests. Iwill see if I can get one soon

@AlCalzone

This comment has been minimized.

Contributor

AlCalzone commented Apr 4, 2017

Any idea when this is going to be included officially?


Edit:
I'm struggling to get this to work. I forked the official repo and merged this pull request, as can be seen here.
I then built the library on my Pi 2 using sudo make && sudo make install. OZW_Log.txt shows its running under version 1.5.0, so I guess that was successful.
However, I'm still getting the error mentioned here
Am I missing something? Another PR maybe?

@johanleire

This comment has been minimized.

johanleire commented Apr 13, 2017

I'm trying to get a Wallmote to work.
I'm using OZW 1.4-2495-g02c3ef6-dirty compiled with the new CentralScene files with Domoticz V3.6775.

The log file looks like this then I push a button:
2017-04-13 11:17:29.269 Info, Node030, Received Central Scene set from node 30: scene id=3 in 0 seconds. Sending event notification.
2017-04-13 11:17:29.270 Warning, Node030, No ValueID created for Scene 3

Does my installation look correct to you?
Whats the next step?

@gizmocuz

This comment has been minimized.

Contributor

gizmocuz commented Apr 16, 2017

@johanleire, thats because support for this kind of implementation also has to be build into the end applications.
(should now work in beta # 7325)

@willemstoker

This comment has been minimized.

willemstoker commented Apr 17, 2017

@johanleire what's your status with the Wallmote? Want to use this thing with Domoticz too. Thanks!

@johanleire

This comment has been minimized.

johanleire commented Apr 17, 2017

@gizmocuz I now have V3.7349. I have added the controller to the groups under "Groups & Networks". When I try to learn the switches in a scene i got this in the OZW log:
2017-04-17 22:56:33.794 Info, Node031, Received Central Scene set from node 31: scene id=2 in 0 seconds. Sending event notification.
2017-04-17 22:56:33.795 Warning, Node031, No ValueID created for Scene 2

@stephanvierkant

This comment has been minimized.

stephanvierkant commented Oct 25, 2017

I agree with @danibaumann. As a PHP-developer I'm not able to contribute, but I will donate if that helps to give this issue some priority.

@KevinK4711

This comment has been minimized.

KevinK4711 commented Nov 8, 2017

I've got the same issue and I'm very interested in any kind of a tactical solution or a proper solution. If there is anything I could help out with in order to support you guys providing a solution let me know.

@gizmocuz

This comment has been minimized.

Contributor

gizmocuz commented Nov 9, 2017

@KevinK4711, as you can read in this topic there are a few software applications already supporting this patch

@AlCalzone

This comment has been minimized.

Contributor

AlCalzone commented Nov 9, 2017

@gizmocuz I referred him from the ioBroker repo. ioBroker is using the node-openzwave-shared library but I had no success so far getting that combination to work. The issue is the same as in #1125 (comment)
Using other applications is not possible in that context.

@gizmocuz

This comment has been minimized.

Contributor

gizmocuz commented Nov 9, 2017

i do not want to advertise my software here, but you might want to give Domoticz as try...

@liquidox

This comment has been minimized.

liquidox commented Nov 16, 2017

Doesn't Domoticz just use OpenZwave? How would that help solve this problem then.

@michapr

This comment has been minimized.

michapr commented Nov 16, 2017

@liquidox : Yes, Domoticz is using OpenZWave, but here was compiled the patch into the current build.
So CentralScene is working as described.

@OpenZWave OpenZWave deleted a comment from liquidox Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from gizmocuz Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from liquidox Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from gizmocuz Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from liquidox Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from gizmocuz Nov 16, 2017

@OpenZWave OpenZWave deleted a comment from AlCalzone Nov 16, 2017

@JudgeDreddKLC

This comment has been minimized.

Contributor

JudgeDreddKLC commented Nov 30, 2017

Thank you all for all the hard work and time dedicated to this!

@AlCalzone

This comment has been minimized.

Contributor

AlCalzone commented Nov 30, 2017

Still looking for input on how to get this to work with my setup.
Was the patch for Domoticz applied to the Dev branch or master? Anything else I have to take care of?
I would appreciate some tips @gizmocuz @michapr

@thundergreen

This comment has been minimized.

thundergreen commented Jan 2, 2018

how to get this for python version?

Zkral added a commit to Zkral/open-zwave that referenced this pull request Feb 23, 2018

MultiChannelAssociation CC: fixed m_alwaysSetInstance / ForceInstance…
…s XML attributes

The meaning of this settings was reversed (enabled by default) by commit a5305f0 "Import CentralScene PR OpenZWave#1125 and More work on the Controlled/Controlling CC support", this revert this change.
@gxapplications

This comment has been minimized.

gxapplications commented Jun 12, 2018

Need this for a while !

@lukescott

This comment has been minimized.

lukescott commented Jul 29, 2018

What is the current state of this? It looks like the changes are already on the dev branch.

@AddoSolutions

This comment has been minimized.

AddoSolutions commented Aug 10, 2018

Anything I can do to get this merged up?

@nicxvan

This comment has been minimized.

nicxvan commented Sep 2, 2018

Is there anything we can do to get this merged?

@robbiet480

This comment has been minimized.

Contributor

robbiet480 commented Sep 5, 2018

This got merged by @Fishwaldo a while ago at a5305f0. Closing as such. Thanks y'all!

@robbiet480 robbiet480 closed this Sep 5, 2018

@stromnet

This comment has been minimized.

Contributor

stromnet commented Sep 6, 2018

@robbiet480 At the time of the merge, @Fishwaldo mentioned CentralScene requires a lot of core changes as well to function correctly, so its not anywhere near ready, but I'll use this PR as a base for support.

Is this core support in place as well?

AlbertoLopSie added a commit to AlbertoLopSie/open-zwave that referenced this pull request Oct 3, 2018

AlbertoLopSie added a commit to AlbertoLopSie/open-zwave that referenced this pull request Oct 4, 2018

Merge pull request #5 from AlbertoLopSie/cscene
Adds support for CC_CENTRAL_SCENE as the PR OpenZWave#1125

@Fishwaldo Fishwaldo referenced this pull request Oct 5, 2018

Closed

CC Central Scene support #1616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment