Implemented simple ReopenLogFile

[electrofloat]

This is a base for #465

[Fishwaldo]

This doesn't really do anything (especially if AppendLog is true) as it just closes and opens the log file. For rotation, we need to rename the old log file and start a new one (regardless of AppendLog) so yes - a base, but still needs some work.

[electrofloat]

This doesn't really do anything (especially if AppendLog is true) as it just closes and opens the log file.

Exactly.

For rotation, we need to rename the old log file and start a new one (regardless of AppendLog) so yes - a base, but still needs some work.

The rotation is the not job of the lib itself. Logrotate does the rotation (on linux), sends a SIGHUP to the app, the app calls ReopenLogfile in the lib, which reopens the same logfile and everything works as expected.

[Fishwaldo]

Your assuming Linux and Systems with logrotate. Windows/Mac/Solaris etc etc etc may not/do not have such a thing. Hence the actual rename of the log file should be done in the library.

I appriciate the PR - I'll update it eventually. :)

[electrofloat]

That is true. Since the issue was mainly talking about logrotate (#465 (comment)) and not handling SIGHUP in the lib (#465 (comment))

That is what I implemented. I'd really appreciate some kind of logrotation for the log it creates either by logrotate or by any other means.

[Fishwaldo]

It just needs a rename between the close/open calls... (but needs to implemented in the platform abstraction classes so its portable).

Question begs - What do we rename to, and how do we handle duplicates etc.

I'll get to it one day :)

[Fishwaldo]

Related to #2146

[Fishwaldo]

Merged to Dev Branch. Thanks!