-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ERC721 Enumerate extension #722
Comments
Is there any concern to not have done it yet (maybe this issue #207)? Also are you comfortable to split the current ERC721 implementation between ERC721 and ERC721Metadata (in order to have ERC721Metadata defined as an extension separated from the core ERC721)? |
@bal7hazar i think the best is to wait for components to streamline this eventual separation. |
@martriay thanks for sharing your thoughts, just to ensure I understand well, do you think it's risky for the community if OZ repo have a pre-component implementation right now and make another other one after the component feature is released (with the risk of changing the signature or storage making the upgrade not possible easily) ? I understand that you could have other priority, my point is if I (or someone else) make a PR with a proposition right now, would you accept to merge it in the repo? (Assuming it passes the merging process ofc). |
@bal7hazar sorry for the long silence. are you still willing to work on this? |
Hey @martriay actually there is already a component version made by Seraph-Labs: |
Great! That'd be a useful reference. We're still going to add this to our library, I expect us to work tackle it sometime during Q1 2024. Anyone interested in tackling it before will be welcomed :) |
🧐 Motivation
To be feature partiy with the Cairo 0 version, having a ERC721 Enumerable extension proposition would be interesting.
📝 Details
Here are 2 repo which did an implementation:
The text was updated successfully, but these errors were encountered: