Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages for require statements #147

Open
paulinablaszk opened this issue Aug 1, 2019 · 4 comments
Open

Add error messages for require statements #147

paulinablaszk opened this issue Aug 1, 2019 · 4 comments

Comments

@paulinablaszk
Copy link
Contributor

I think we should add error messages for all require (and assert) statements in contracts. What do you think about the format of reason strings? I think it should be consistent with other OpenZeppelin contracts

@abcoathup
Copy link
Contributor

I agree that the format should be consistent with other OpenZeppelin contracts.

Should we wait until #117 is done and then update or do it as part of that? I am keen to get the upgrade to Solidity 0.5 complete.

@vibern0
Copy link

vibern0 commented Aug 1, 2019

I don't have good experience with require error messages on ropsten. How about you guys?
And this seems to be the solution (or the problem) ethereum/go-ethereum#18360
Also, we should wait until #117 is merged and then move on with everything else, in my opinion.

@paulinablaszk
Copy link
Contributor Author

I agree we have to wait for the update to Solidity 0.5, I was thinking about adding error messages during #177 but I didn't want to mix these issues.
I think that even if error messages are not supported by all clients, it might be a
example of good practices for people learning Solidity, because it is helpful in the development process

@xaler5
Copy link
Collaborator

xaler5 commented Dec 25, 2022

@paulinablaszk are there still requires without messages ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 To Do
Development

No branches or pull requests

4 participants