Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please mark virtual override in ERC721 ownerOf (and potentially others) #2373

Closed
3esmit opened this issue Sep 25, 2020 · 1 comment
Closed

Please mark virtual override in ERC721 ownerOf (and potentially others) #2373

3esmit opened this issue Sep 25, 2020 · 1 comment

Comments

@3esmit
Copy link

3esmit commented Sep 25, 2020

I am unable to update to solidity 0.6.2 for using ENS in my project.

This is where it breaks
https://github.com/ensdomains/ethregistrar/blob/75b4515b33ff06f4e5e980c36a9a5214e7d1bd4c/contracts/BaseRegistrarImplementation.sol#L46-L49

As workaround I copied ERC721.sol to my project folder and I am using it instead of openzeppelin version.
@3esmit 3esmit mentioned this issue Sep 25, 2020
Merged
@frangio frangio changed the title Please mark virtual override in ERC721 ownerOf (and potentially others) Virtual view functions Oct 13, 2020
@frangio frangio changed the title Virtual view functions Please mark virtual override in ERC721 ownerOf (and potentially others) Oct 13, 2020
@frangio
Copy link
Contributor

frangio commented Oct 13, 2020

Thanks for reporting @3esmit. See #2154. I'll be collecting over there all the functions that have been requested to be made virtual.

@frangio frangio closed this as completed Oct 13, 2020
@frangio frangio mentioned this issue Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3esmit @frangio