Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Detect initial values in fields declarations and throw a warning #80

Closed
spalladino opened this issue Sep 6, 2018 · 4 comments
Closed
Labels
kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations
Milestone

Comments

@spalladino
Copy link
Contributor

spalladino commented Sep 6, 2018

Setting an initial value for a field when declaring it does not work for proxies, since the value is set in the constructor (see #60 and #79 for more info).

contract MyContract {
  uint256 public hasInitialValue = 42;
}

Note that this is not a problem if the field is defined as constant.

We should detect these scenarios, in all contracts (plus their ancestors) and raise a warning. This warning should be run when adding pushing the contract.

@spalladino spalladino added gitcoin:bounty worthy Good candidate for a gitcoin bounty kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations component:cli labels Sep 6, 2018
@spalladino spalladino added this to the Backlog milestone Sep 6, 2018
@facuspagnuolo facuspagnuolo modified the milestones: Backlog, v2.0.0 Sep 13, 2018
@vs77bb
Copy link

vs77bb commented Sep 18, 2018

Hi @spalladino Think I should put up a bounty here / elsewhere with the label bounty-worthy? Can do, if you think they're ready 👍

@spalladino
Copy link
Contributor Author

Thanks a lot @vs77bb! We've been shuffling around priorities with @facuspagnuolo during these last few days, so we'll review the bounty-worthy labeled issues. We'll be removing the labels from those issues that we plan on tackling internally during the next 6 weeks, and add it to the ones that fell outside of the last planning, but would be nice-to-have nonetheless. We'll keep you posted!

@facuspagnuolo facuspagnuolo removed the gitcoin:bounty worthy Good candidate for a gitcoin bounty label Sep 20, 2018
@facuspagnuolo
Copy link
Contributor

Hey @vs77bb! We already organized the issues and the bounty-worthy labels :)

@vs77bb
Copy link

vs77bb commented Sep 25, 2018

@facuspagnuolo Just posted four bounties across those listed bounty worthy 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement Enhancement to an existing feature topic:storage-checks Storage compatibility validations
Projects
None yet
Development

No branches or pull requests

3 participants