Transfer replacement #1962
Merged
Transfer replacement #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
added
feature
|
This should go into the 2.4 release, but I started the branch from |
|
Cherry-picking aftewards is the "protocol". |
frangio
reviewed
Oct 24, 2019
nventuro
force-pushed
the
transfer-replacement
branch
from
4e57636
to
f5e354a
Compare
igorline
reviewed
Oct 28, 2019
| @@ -10,6 +10,7 @@ | |||
| ### New features: | |||
| * `Address.toPayable`: added a helper to convert between address types without having to resort to low-level casting. ([#1773](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1773)) | |||
| * Facilities to make metatransaction-enabled contracts through the Gas Station Network. ([#1844](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/1844)) | |||
| * `Address.sendValue`: added a replacement to Solidity's `transfer`, removing the fixed gas stipend. ([#1961](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1961)) | |||
There was a problem hiding this comment.
Yes, good catch. I'll fix it on master.
frangio
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Add Address.sendEther * Add documentation to sendEther * Add changelog entry * Rename sendEther to sendValue (cherry picked from commit 8d166f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a replacement for Solidity's
transfer, which imposes a fixed gas limit of 2300. While useful to prevent reentrancy issues, this has proved to be an issue due to gas repricings, like the one EIP1884 will introduce on the Instanbul hardfork.Given that the code to imitate
transferis tricky and cryptic, having a helper method to do it is a good idea.