feat(components): create new Tag component #15441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
mjhuff,
koji,
shlokamin,
mmencarelli and
ncdiehl11
and removed request for
a team
ncdiehl11
approved these changes
Jun 17, 2024
| {iconName != null && iconPosition === 'left' ? ( | ||
| <Icon name={iconName} aria-label={`icon_${text}`} css={ICON_STYLE} /> | ||
| ) : null} | ||
| <StyledText css={TEXT_STYLE}>{text}</StyledText> |
There was a problem hiding this comment.
nit: can we use as='h3' to avoid redundancy?
There was a problem hiding this comment.
i think that the h3 StyledText tag doesn't translate correctly for the ODD so i'd have to override it still with the css prop
koji
reviewed
Jun 17, 2024
koji
reviewed
Jun 17, 2024
koji
reviewed
Jun 17, 2024
|
Could you add tests for Tag component? I think need to add Tag to |
koji
reviewed
Jun 18, 2024
koji
reviewed
Jun 18, 2024
koji
reviewed
Jun 18, 2024
|
@jerader |
koji
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RSQ-84 https://opentrons.atlassian.net/browse/RSQ-84
Overview
This PR creates the Tag component that was added to the design system. Additionally, it deprecates the usage of the
basictype inChipcomponentTest Plan
Search for
Tagin Storybook and look through the different props. Make sure it matches the Figma designsChangelog
basictype from Chip component, story and testNOTE: i did not make a test for this component. I think atoms in the components directory like this are not as important to have a test since we can check how it looks/works via the story
Review requests
see test plan
Risk assessment
low