Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix tasklist modal position #16103

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(app): fix tasklist modal position #16103

merged 1 commit into from
Aug 26, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 23, 2024 •
edited
Loading

Overview

fix tasklist modal position

RQA-

tasklist.mov

Test Plan and Hands on Testing

  • OT-2 robot settings
  • pipette calibration

Changelog

  • add marginLeft: 0

Review requests

Risk assessment

low

@koji
fix(app): fix tasklist modal position
6928e81 
fix tasklist modal position
@koji koji changed the base branch from edge to chore_release-8.0.0 August 23, 2024 01:13
@koji koji marked this pull request as ready for review August 25, 2024 23:29
@koji koji requested a review from a team as a code owner August 25, 2024 23:29
@koji koji requested review from ncdiehl11, mjhuff and jerader and removed request for a team August 25, 2024 23:29
ncdiehl11
ncdiehl11 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji merged commit b005304 into chore_release-8.0.0 Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

@mjhuff mjhuff Awaiting requested review from mjhuff

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @ncdiehl11