-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove minor bug and made plugin compatible for release 2021.3 #343
Conversation
… entry from git config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Please address the minor issues in the bugfix bug fix and remove the change in the gradle config.
Version compatibility is a different issue that I'm tackling separately
//get the base branch for this bugfix | ||
final String baseBranch = gitflowConfigUtil.getBaseBranch(branchUtil.getPrefixBugfix()+bugfixName); | ||
|
||
if (result.success()) { | ||
GitCommandResult result = myGitflow.finishBugfix(myRepo, bugfixName, errorLineHandler); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the white space issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering that there was no activity on this PR, I think you'd have to change that yourself.
what is the timeline to merge this please ? thanks |
@medbenmakhlouf I built the project reproducing @homburgs #343 commits. It runs in Pycharm 2021.3 RC2 and the gold, 2021.3. I'm using it in Pycharm If someone wants to do this on their own you have to build the .jar file with intellij ultimate. Instructions in this issue. Or download and unzip the following: Instructions to manually install this or your own jar build for pycharm are here. There are good reasons opherV does not rush releases. While I'm using this successfully myself, use this at your own risk. :) See below for minor possible bug: |
Can anyone duplicate a bug I'm seeing in the manual temporary build I posted above? After installing the plugin manually, and restarting Pycharm, I was no longer seeing git flow in the toolbar (as though it was not installed) and it was not in the "installed" or "marketplace" plugins list when searching for "git flow". I suspect it is a bug, but could be because I didn't update the plugin version number or install file as I roughshod threw together this temporary patch? The reason I noticed is that gitflow seemed to disappear. Then when I went to manually install it again, and restart. It reappeared in the toolbar, and also in the plugins Installed list. |
No description provided.