Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove minor bug and made plugin compatible for release 2021.3 #343

Closed
wants to merge 3 commits into from
Closed

remove minor bug and made plugin compatible for release 2021.3 #343

wants to merge 3 commits into from

Conversation

homburgs
Copy link

@homburgs homburgs commented Dec 1, 2021

No description provided.

Copy link
Owner

@OpherV OpherV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Please address the minor issues in the bugfix bug fix and remove the change in the gradle config.

Version compatibility is a different issue that I'm tackling separately

//get the base branch for this bugfix
final String baseBranch = gitflowConfigUtil.getBaseBranch(branchUtil.getPrefixBugfix()+bugfixName);

if (result.success()) {
GitCommandResult result = myGitflow.finishBugfix(myRepo, bugfixName, errorLineHandler);

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the white space issues

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering that there was no activity on this PR, I think you'd have to change that yourself.

@medbenmakhlouf
Copy link

what is the timeline to merge this please ? thanks

banagale added a commit to banagale/gitflow4idea that referenced this pull request Dec 5, 2021
@banagale
Copy link

banagale commented Dec 5, 2021

@medbenmakhlouf I built the project reproducing @homburgs #343 commits.

It runs in Pycharm 2021.3 RC2 and the gold, 2021.3. I'm using it in Pycharm Build #PY-213.5744.248, built on November 29, 2021

If someone wants to do this on their own you have to build the .jar file with intellij ultimate. Instructions in this issue.

Or download and unzip the following:

Instructions to manually install this or your own jar build for pycharm are here.

There are good reasons opherV does not rush releases.

While I'm using this successfully myself, use this at your own risk. :)

See below for minor possible bug:

@banagale
Copy link

banagale commented Dec 13, 2021

Can anyone duplicate a bug I'm seeing in the manual temporary build I posted above?

After installing the plugin manually, and restarting Pycharm, I was no longer seeing git flow in the toolbar (as though it was not installed) and it was not in the "installed" or "marketplace" plugins list when searching for "git flow".

I suspect it is a bug, but could be because I didn't update the plugin version number or install file as I roughshod threw together this temporary patch?

The reason I noticed is that gitflow seemed to disappear. Then when I went to manually install it again, and restart. It reappeared in the toolbar, and also in the plugins Installed list.

@homburgs homburgs closed this by deleting the head repository Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants