Skip to content
This repository has been archived by the owner on May 2, 2020. It is now read-only.

Updated DateTimeValue entity with date/string conversions #4

Merged
merged 2 commits into from
Dec 30, 2014
Merged

Updated DateTimeValue entity with date/string conversions #4

merged 2 commits into from
Dec 30, 2014

Conversation

denmit
Copy link
Contributor

@denmit denmit commented Dec 30, 2014

No description provided.

@rvanlaarhoven
Copy link
Contributor

Thanks, but I think getValue() should return a DateTime object and setValue() should require a DateTime object as the parameter. Then inside the methods you should convert the DateTime values from/to timestamps.

rvanlaarhoven added a commit that referenced this pull request Dec 30, 2014
@rvanlaarhoven
Merge pull request #4 from Opifer/denis-cms-update
866f81d 
Updated DateTimeValue entity with date/string conversions
@rvanlaarhoven rvanlaarhoven merged commit 866f81d into master Dec 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rvanlaarhoven rvanlaarhoven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denmit @rvanlaarhoven