Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to ESM sandboxed jobs #2085

Closed
wants to merge 1 commit into from

Conversation

mcolmant
Copy link

@mcolmant mcolmant commented Jul 6, 2021

Hello,

Thanks for all the work you did on bull.

As NodeJS 10 is now dead since April, I propose to correctly support ESM sandboxed jobs.
It will be a big improvement for us as we are moving to ESM modules.

Let me know if you need something else.

@Sparksx
Copy link

Sparksx commented Jul 8, 2021

Nice work @mcolmant

@manast
Copy link
Member

manast commented Jul 8, 2021

Thanks for the nice PR. Just wondering if this change will break existing deployments that are still using node 10. If so it will be a breaking change and we need to release a major version. I guess the tests fails in node 10 and thats why you removed them from the CI script?

@mcolmant
Copy link
Author

mcolmant commented Jul 8, 2021

Hello @manast, thanks for your quick answer.
I pushed a new commit to fix few errors I made.

Yes, you're right, the import statements are not supported by default in node 10.
Moreover, this version is now ended as quoted from NodeJS.

You're right, it should be a major release if it's accepted.

@manast
Copy link
Member

manast commented Jul 8, 2021

Gonna delay the merge of this one for a while because there are still some more stuff that I want to incorporate into 3.x.

@mcolmant
Copy link
Author

mcolmant commented Jul 9, 2021

Ok, I understand. I will keep this fork updated until it can be released and will use it for now.
Could I propose the same changes for bullmq?

@manast
Copy link
Member

manast commented Jul 9, 2021

Ok, I understand. I will keep this fork updated until it can be released and will use it for now.
Could I propose the same changes for bullmq?

Sure. Since it is typescript maybe it will not be a breaking change, not sure.

@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2021
@stale stale bot closed this Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants