Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support upper case in the domain #57

Closed
yeya opened this issue Jun 24, 2016 · 3 comments
Closed

Support upper case in the domain #57

yeya opened this issue Jun 24, 2016 · 3 comments
Assignees
@manast
Labels
enhancement

Comments

@yeya
Copy link

yeya commented Jun 24, 2016

Hi there

It looks like redbird can not proxy requests with upper cases.
I have old clients trying to get to Support.example.com.
I tried to:
proxy.register("Support.example.com", "http://localhost:1234");
but redbird ignore the uppercase, so I always get:

"msg":"no valid route found for given source"
@manast manast self-assigned this Jun 24, 2016
@manast
Copy link
Member

manast commented Jun 24, 2016

domain names should be case insensitive, this is a bug in redbird.

@manast manast closed this as completed in 8e72b6b Jun 24, 2016
@yeya
Copy link
Author

yeya commented Jun 25, 2016

Great!!! Thank you.
Can you please just update the version to allow easy fix by npm update?

@manast
Copy link
Member

manast commented Jun 26, 2016

done!.

@yeya yeya mentioned this issue Jun 26, 2016
Closed
logbon72 pushed a commit to logbon72/redbird that referenced this issue Aug 2, 2016
Merge branch 'master' of https://github.com/OptimalBits/redbird
80d715f 
* 'master' of https://github.com/OptimalBits/redbird: (25 commits)
  0.5.3
  re-fixed OptimalBits#58
  0.5.2
  fix for OptimalBits#58
  0.5.1
  fixed OptimalBits#57
  0.5.0
  Oops, it's just HTTP request/response, not Express
  Update etcd-backend.js
  Added anchor links, which seems to have been half-set-up already
  update README for notFound
  Give notFound both req and res as params
  Add notFound function to set respondNotFound callback (OptimalBits#44)
  refactored should redirect to https
  refactored proxy error handler
  removed incorrect files
  removed incorrect files
  0.4.15
  upgraded several dependencies
  fixed OptimalBits#49
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manast manast

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manast @yeya