Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code exection class and test cases #674

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

Bob17293729
Copy link

created code execution class and add some testcases.

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add code execution for special strings generated by tool-models (agents) to call python. The basic functionality looks fine, some features are missing but can be added later

examples/tool_inference.py

  • [Feature] line 20: better use HfArgumentParser, so that argument in inferencer can be supported.

scripts/run_tool.sh

  • [Bug] line 1: use a huggingface model instead of a local model, otherwise other users cannot use it.

src/lmflow/pipeline/inferencer.py

  • [Style] line 623, 628, 626, 632: comments and outputs in English are strongly preferred, so that contributors from different countries can understand.

tests/models/test_tool_inferencer.py

  • [Style] Use set_up for function names as instructed by Google python coding style.
  • [Feature] Error handling tests are recommended.

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@research4pan research4pan merged commit 8516a72 into OptimalScale:main Dec 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants