conversation dataset (sharegpt format) custom template dev #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheresmyhair
changed the title
research4pan
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM, thanks! Two small questions that may help everyone use this feature easier:
- I am wondering if there are examples of typical templates, ranked according to their popularity.
- I am wondering how users can specify their own template in the data without modifying the code.
src/lmflow/models/hf_decoder_model.py
- line 467-483: we can use mapping instead of a list of
if-else, which is both more efficient and easier to maintain, but this can be improved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for review