Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/doc fixes for open source #150

Merged
merged 2 commits into from
Dec 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,27 @@ assignees: ''
---

**Version information**
<!--
- The version of DCE.
- OS and version
- Go version
- Terraform version (if using directly)
-->

**Describe the bug**
A clear and concise description of what the bug is.
<!-- A clear and concise description of what the bug is. -->

**To Reproduce**
<!--
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
-->

**Expected behavior**
A clear and concise description of what you expected to happen.
<!-- A clear and concise description of what you expected to happen. -->

**Additional context**
Add any other context about the problem here.
<!-- Add any other context about the problem here. -->
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ assignees: ''
---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the solution you'd like**
A clear and concise description of what you want to happen.
<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**
Add any other context or screenshots about the feature request here.
<!-- Add any other context or screenshots about the feature request here.-->
17 changes: 1 addition & 16 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Describe the big picture of your changes here to communicate to the maintainers
## Types of changes

<!--
What types of changes does your code introduce to the module?
What types of changes does your code introduce to the repo?
Put an `x` in the boxes that apply
-->

Expand All @@ -31,21 +31,6 @@ Put an `x` in the boxes that apply. You can also fill these out after creating t
- [ ] I have updated the `CHANGELOG.md` under a `## next` release, with a short summary of my changes


## Dependencies and Blockers



<!--

Is there anything preventing this PR from being merged and deployed to prod?

eg. other PRs that are required, external blockers, etc.

If so, this is a high-risk deployment, and we should call this out for manual attention

-->


## Relevant Links

<!--
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ override.tf.json

# Other stuff
*.zip
.idea/

junit-report/
test.output.txt
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ We have some general guidelines towards contributing to this project.

*Go*

The source code for this project is written in Go. You are welcome to add versions of files for other languages, however the core code will remain in Go.
The Lambda and CodeBuild function code is written in Golang. We prefer that similar contributed code also be written in Golang. Please ensure your Golang code is formatted by [gofmt](https://golang.org/cmd/gofmt/) and linted by [golint](https://godoc.org/golang.org/x/lint).

## Pull Requests

Expand Down