Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get latest aws-nuke release. #432

Merged
merged 12 commits into from
Mar 9, 2023
Merged

fix: get latest aws-nuke release. #432

merged 12 commits into from
Mar 9, 2023

Conversation

jrsholly
Copy link
Collaborator

@jrsholly jrsholly commented Jan 13, 2023

Types of changes

Get the latest release version on aws-nuke. Old version isn't cleaning up all resources in accounts resulting in dirty accounts.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

https://github.com/rebuy-de/aws-nuke

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jrsholly
✅ shubydo
❌ Shollenbarger


Shollenbarger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jrsholly jrsholly changed the title fix: get latest aws-nuke release. Stop using fork of aws-nuke fix: get latest aws-nuke release. Jan 24, 2023
Copy link
Collaborator

@shubydo shubydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove .DS_Store and add it to the .gitignore?

shubydo

This comment was marked as duplicate.

@jrsholly jrsholly merged commit d4dfa38 into master Mar 9, 2023
@jrsholly jrsholly deleted the fix/getLatestAws-Nuke branch March 9, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants