-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main
@ef9d853
#1108
Merge main
@ef9d853
#1108
Conversation
6d069aa
to
a613c38
Compare
Isabelle's comments:On
On
On
LM's one(s):
|
Should be fixed with 0ec87a2 |
This comment was marked as resolved.
This comment was marked as resolved.
…c9eea7c2562e5d9) (1st part)
0ec87a2
to
e235e4b
Compare
Fixed it with 72f427b. But this modification needs to check non-regression between buttons, dropdowns and split buttons. Edit: I simplified the box shadows colors with 0abd7db. Otherwise |
e2ba863 allows to handle more precisely the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor issues can be handled later IMO.
Minor issues detected :
- .btn-inverse.btn-close:focus is a bit weird : was already here
- .btn-link outline doesn't move anymore
🙏 Dear reviewer please check in details: