-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore merge from 18a400a to fee563d #2202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-chore-merge-from-18a400a
branch
from
August 23, 2023 04:30
9fde6a3
to
2facfcd
Compare
julien-deramond
changed the title
Chore merge from 18a400a
Chore merge from 18a400a to fee563d
Aug 23, 2023
louismaximepiton
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some bytes saved, well done! I think I forgot to run oxipng against the new images, nice to see it happen 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find site -name "*.png" | xargs oxipng -omax -Z
for PNGs. Unfortunately, I haven't found the right options used upstream; running it betweenv5.3.1
andmain
didn't make any changes on Bootstrap.jpegoptim
because we don't have any JPEG files, but updated https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/wiki/Add-an-example to mention this tooltwbs/bootstrap@dc040fa: we don't have this example in Boosted so nothing to do here