Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't click on a link placed in a tooltip #248

Merged

Conversation

jacques-lebourgeois
Copy link
Member

Related issues

Description

The tooltip moves and is not clickable

Motivation & Context

I need to add a link in the tooltip and can't click on it

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@jacques-lebourgeois jacques-lebourgeois linked an issue May 30, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented May 30, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit ac39c7d
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/666c4176747ffe00087f9a8e
😎 Deploy Preview https://deploy-preview-248--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois jacques-lebourgeois force-pushed the 247-cant-click-on-a-link-placed-in-a-tooltip branch from f9289f7 to e3fa538 Compare May 30, 2024 15:30
@jacques-lebourgeois jacques-lebourgeois self-assigned this May 30, 2024
@jacques-lebourgeois jacques-lebourgeois added the bug Something isn't working label May 30, 2024
@jacques-lebourgeois jacques-lebourgeois marked this pull request as ready for review May 30, 2024 15:32
@jacques-lebourgeois jacques-lebourgeois force-pushed the 247-cant-click-on-a-link-placed-in-a-tooltip branch from e3fa538 to 2142496 Compare May 30, 2024 15:34
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me apart one point : the one that forces users to use Echarts renderer.
Otherwise, some stuff for later and some UX questions.

docs/use_cases/tooltip.html Show resolved Hide resolved
docs/use_cases/tooltip.html Show resolved Hide resolved
docs/use_cases/tooltip.html Outdated Show resolved Hide resolved
docs/use_cases/tooltip.html Show resolved Hide resolved
@jacques-lebourgeois jacques-lebourgeois force-pushed the 247-cant-click-on-a-link-placed-in-a-tooltip branch from 2142496 to 4fef6ae Compare June 7, 2024 07:48
@louismaximepiton louismaximepiton mentioned this pull request Jun 7, 2024
2 tasks
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments left and we're good to go 🎉
I couldn't check using Boosted 4 since I couldn't remember the process.

The remaining looks really great with that much examples.

src/theme/popover/ods-chart-popover.ts Show resolved Hide resolved
src/theme/popover/ods-chart-popover.ts Show resolved Hide resolved
src/theme/popover/ods-chart-popover-definitions.ts Outdated Show resolved Hide resolved
@jacques-lebourgeois
Copy link
Member Author

Few comments left and we're good to go 🎉 I couldn't check using Boosted 4 since I couldn't remember the process.

The remaining looks really great with that much examples.

I just push a commit to add enterable tooltip in code generator and then make it testable online with Boosted 4.

Also make a bettre managemnt of tooltip with Boosted 4

if (!enterable) {
window.setTimeout(() => {
try {
elt.chartPopover.tip.style.pointerEvents = 'none';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more like a workaround, but I can't find another right now, let's go with it for now!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not found any class in boosted 4 to do it :(

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for the tooltip delay and all the stuff for v4 ❤️ It looks so smooth in v4

Looks good to me.

@jacques-lebourgeois jacques-lebourgeois merged commit 497f572 into main Jun 14, 2024
5 checks passed
@jacques-lebourgeois jacques-lebourgeois deleted the 247-cant-click-on-a-link-placed-in-a-tooltip branch June 14, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't click on a link placed in a tooltip
2 participants