-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't click on a link placed in a tooltip #248
Can't click on a link placed in a tooltip #248
Conversation
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f9289f7
to
e3fa538
Compare
e3fa538
to
2142496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me apart one point : the one that forces users to use Echarts renderer.
Otherwise, some stuff for later and some UX questions.
2142496
to
4fef6ae
Compare
… NONE or BOOSTED5 renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments left and we're good to go 🎉
I couldn't check using Boosted 4 since I couldn't remember the process.
The remaining looks really great with that much examples.
…quickly : 12 does not work in any case. 15 looks fine.
…estable in generic doc)
I just push a commit to add enterable tooltip in code generator and then make it testable online with Boosted 4. Also make a bettre managemnt of tooltip with Boosted 4 |
if (!enterable) { | ||
window.setTimeout(() => { | ||
try { | ||
elt.chartPopover.tip.style.pointerEvents = 'none'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more like a workaround, but I can't find another right now, let's go with it for now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not found any class in boosted 4 to do it :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch for the tooltip delay and all the stuff for v4 ❤️ It looks so smooth in v4
Looks good to me.
Related issues
Description
The tooltip moves and is not clickable
Motivation & Context
I need to add a link in the tooltip and can't click on it
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examples
test/angular-ngx-echarts
test/angular-echarts
test/html
test/react
test/vue
test/examples/bar-line-chart
test/examples/single-line-chart
test/examples/timeseries-chart