Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add precisions in readme #275

Merged
merged 17 commits into from
Jun 14, 2024
Merged

docs: add precisions in readme #275

merged 17 commits into from
Jun 14, 2024

Conversation

jacques-lebourgeois
Copy link
Member

@jacques-lebourgeois jacques-lebourgeois commented Jun 14, 2024 •
edited by julien-deramond
Loading

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 93690b3
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/666c4bde92bcff0008e6943f
😎 Deploy Preview https://deploy-preview-275--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois jacques-lebourgeois marked this pull request as ready for review June 14, 2024 08:14
julien-deramond
julien-deramond requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked everything, but here are a few comments already.
Plus, Prettier job is failing.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jacques-lebourgeois and others added 9 commits June 14, 2024 13:11
@jacques-lebourgeois @julien-deramond
Update README.md
a766b0d 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@jacques-lebourgeois @julien-deramond
Update README.md
f9afcf7 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@jacques-lebourgeois @julien-deramond
Update README.md
343e990 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@jacques-lebourgeois @julien-deramond
Update README.md
cf6b8ad 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@jacques-lebourgeois @julien-deramond
Update README.md
fc0badb 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@jacques-lebourgeois @julien-deramond
Update README.md
e316f73 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@JacquesParis
Back to a Quick start section
e513485
@jacques-lebourgeois @julien-deramond
Update README.md
c709364 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@JacquesParis
Update README.md
aaf727c
julien-deramond
julien-deramond requested changes Jun 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 14, 2024
jacques-lebourgeois and others added 2 commits June 14, 2024 14:36
@jacques-lebourgeois @julien-deramond
Update README.md
71a7943 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@JacquesParis
jsDelivr not recomended
4271b0a
louismaximepiton
louismaximepiton approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jacques-lebourgeois jacques-lebourgeois self-assigned this Jun 14, 2024
@julien-deramond julien-deramond merged commit d183cc6 into main Jun 14, 2024
5 checks passed
@julien-deramond julien-deramond deleted the doc/readme branch June 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

@jacques-lebourgeois jacques-lebourgeois

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacques-lebourgeois @julien-deramond @louismaximepiton @JacquesParis