Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings driver should not directly release the shell settings #15884

Closed
MikeAlhayek opened this issue Apr 26, 2024 · 0 comments · Fixed by #15875
Closed

Settings driver should not directly release the shell settings #15884

MikeAlhayek opened this issue Apr 26, 2024 · 0 comments · Fixed by #15875

Comments

@MikeAlhayek
Copy link
Member

Currently when a core site settings change, we reload the shell settings directly in the driver. If we have multiple drivers contributing to the same settings group, we run into issue of releasing the shell multiple times or releasing it when unnecessary.

We should have a way for the settings driver to request the tenant to be reloaded. In the controller, we then reload the settings only when we have a request and the settings has been validated.

This should reduce the cost of unnecessary tenant reloading.

@MikeAlhayek MikeAlhayek changed the title Driver settings should not directly release the shell settings Settings drivera should not directly release the shell settings Apr 26, 2024
@hishamco hishamco changed the title Settings drivera should not directly release the shell settings Settings driver should not directly release the shell settings Apr 26, 2024
@Piedone Piedone added the perf label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants