Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect and fix Microsoft Edge (Chromium) issues. #8912

Closed
kdubious opened this issue Mar 19, 2021 · 6 comments
Closed

Inspect and fix Microsoft Edge (Chromium) issues. #8912

kdubious opened this issue Mar 19, 2021 · 6 comments
Labels

Comments

@kdubious
Copy link
Contributor

kdubious commented Mar 19, 2021

Missing x-content-type-options :

image

@Skrypt Skrypt changed the title Missing x-content-type-options Inspect and fix Microsoft Edge (Chromium) issues. Mar 19, 2021
@Skrypt
Copy link
Contributor

Skrypt commented Mar 19, 2021

Ok let's open up a single issue for these that says. Inspect and fix Microsoft Edge (Chromium) issues.
We need to list them and investigate if they are requiring action(s).

@kdubious
Copy link
Contributor Author

kdubious commented Mar 19, 2021

  1. A 'cache-control' header contains directives which are not recommended: 'no-store'
  2. A 'cache-control' header contains directives with invalid values: 's-max-age=31557600'
  3. A 'set-cookie' header doesn't have the 'httponly' directive.
  4. Response should include 'x-content-type-options' header.
  5. The 'Pragma' header should not be used, it is deprecated and is a request header only.
  6. The 'server' header should only contain the server name.
    7. Response should not include disallowed headers: x-powered-by [ignore, see Should not use 'x-powered-by' #8910]

@sebastienros
Copy link
Member

Where is that list of issues/recommendations coming from?

Also I read recently that x-apple-orange is not recommended anymore, and that we should just use apple-orange

@kdubious
Copy link
Contributor Author

@sebastienros, it's coming from me. And I am getting it from the "Issues" tab in "Edge."

https://webhint.io/

@Skrypt
Copy link
Contributor

Skrypt commented Mar 19, 2021

image

@Piedone
Copy link
Member

Piedone commented May 21, 2024

What Edge currently shows are quite different. E.g. on /Admin I see:

image

Only the first is applicable, which is an accessibility issue, tracked under #15222.

The above-mentioned security issues are a matter of configuration and hosting environment (see the Security module and https://github.com/Lombiq/Helpful-Libraries/blob/dev/Lombiq.HelpfulLibraries.OrchardCore/Docs/Security.md), so not generally applicable.

Please open specific issues for specific problems, with a rationale attached.

@Piedone Piedone closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants