Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new hook useContentLoadingIndicator #126

Merged
merged 3 commits into from
Mar 13, 2024
Merged

feat: add new hook useContentLoadingIndicator #126

merged 3 commits into from
Mar 13, 2024

Conversation

mkarajohn
Copy link
Contributor

Description

Screenshot

Test Plan

This was referenced Dec 10, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mkarajohn Graphite App
Copy link
Contributor Author

mkarajohn commented Dec 10, 2023 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mkarajohn and the rest of your teammates on Graphite Graphite

@mkarajohn mkarajohn force-pushed the 12-10-feat_add_new_hook_useContentLoadingIndicator branch from 8bf049f to c7931e5 Compare December 14, 2023 10:41
@orfium-sonarqube-app Orfium SonarQube App
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 22.9% 22.9% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@mkarajohn mkarajohn mentioned this pull request Jan 8, 2024
Merged
@mkarajohn mkarajohn mentioned this pull request Jan 25, 2024
Merged
@panvourtsis panvourtsis mentioned this pull request Feb 20, 2024
Merged
@mkarajohn mkarajohn force-pushed the 12-08-feat_implement_sidebar_changes_based_on_dqa_and_handle_scrolling branch from 4c64eb7 to 5cae662 Compare February 20, 2024 14:16
@mkarajohn mkarajohn force-pushed the 12-10-feat_add_new_hook_useContentLoadingIndicator branch from e1894e6 to a53f771 Compare February 20, 2024 14:16
@orfium-sonarqube-app Orfium SonarQube App
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 22.9% 22.9% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@mkarajohn mkarajohn mentioned this pull request Feb 25, 2024
Closed
@mkarajohn mkarajohn force-pushed the 12-08-feat_implement_sidebar_changes_based_on_dqa_and_handle_scrolling branch from 5cae662 to fd37a13 Compare March 13, 2024 11:19
@mkarajohn mkarajohn force-pushed the 12-10-feat_add_new_hook_useContentLoadingIndicator branch from a53f771 to ccb146e Compare March 13, 2024 11:19
@mkarajohn Graphite App
Copy link
Contributor Author

mkarajohn commented Mar 13, 2024 •
edited
Loading

Merge activity

  • Mar 13, 7:45 AM EDT: @mkarajohn started a stack merge that includes this pull request via Graphite.
  • Mar 13, 9:17 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 13, 9:18 AM EDT: @mkarajohn merged this pull request with Graphite.

@mkarajohn mkarajohn force-pushed the 12-08-feat_implement_sidebar_changes_based_on_dqa_and_handle_scrolling branch from fd37a13 to bfb58a4 Compare March 13, 2024 13:12
@mkarajohn mkarajohn changed the base branch from 12-08-feat_implement_sidebar_changes_based_on_dqa_and_handle_scrolling to master March 13, 2024 13:14
@mkarajohn mkarajohn force-pushed the 12-10-feat_add_new_hook_useContentLoadingIndicator branch from ccb146e to 886aae2 Compare March 13, 2024 13:16
@mkarajohn mkarajohn merged commit 80df1bf into master Mar 13, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panvourtsis panvourtsis panvourtsis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkarajohn @panvourtsis