progression: add item IsActionBlocked exception mechanism

[nbusseneau]

In vanilla, it is possible to find Poison Arrows in Sunken Crypts in the Swamp, even though they cannot be crafted until finding Obsidian in the mountain.

This change adds an exception similar to the existing exceptions for Entrails, allowing Poison Arrows to be used as soon as the right biome is accessible, bypassing the recipe check.

[Jonny-Havoc]

Please merge this @OrianaVenture

[nbusseneau]

Let me know if I can do anything to get this merged 😄

[OrianaVenture]

It is not my intention to be able to use poison arrows until defeating bonemass. They are the same damage level as obsidian and frost arrows, and I think they need to be treated as such. To get around this people are free to use other mods to alter the recipe of poison arrows to use different ingredients, and make other adjustments like the mod Wacky's Database.

Eventually I want to allow full customization of the locking system. When that feature is implemented there will be ways to reassign items and the keys required to unlock their usage. This will include checking just for prefab names rather than their recipes.

[nbusseneau]

It is not my intention to be able to use poison arrows until defeating bonemass. They are the same damage level as obsidian and frost arrows, and I think they need to be treated as such.

The thing is they're a vanilla item found in vanilla Sunken Crypts before defeating Bonemass, so as it stands the mod is creating a frustrating situation for players because they find an item in a legitimate way, not bypassing the regular progression, and they can't use it (in particular this is very annoying for first time players discovering the game).

Also the mod already has a similar situation with Entrails since they can be found in Meadows, and there's already an exception for that one, so it felt consistent to me to fix it 😄

[nbusseneau]

(FWIW, I had so many users complain about this that I actually implemented this PR as a separate patch in our modpack, without having to wait for a decision to be taken here 😅)

[OrianaVenture]

If your external patch is working for you and your players I encourage it. If it is something that can be shared to thunderstore as an external module I can then even recommend it to other players who feel the same way. Another issue with hard coding an exception for poison arrows would be if they were already changed to alter the progression in another way - the exception now needs to be optional which falls into the customization feature I still need to implement. So this is out of scope currently and will not be merged in.

[nbusseneau]

Another issue with hard coding an exception for poison arrows would be if they were already changed to alter the progression in another way - the exception now needs to be optional which falls into the customization feature I still need to implement.

If the issue was addressed independently, of course that needs to be changed once the bug fix is merged, but that's just expected and "business as usual" 😅

I really think we're in a "perfect is the enemy of good" situation right now: by itself, the mod actively creates a quirky situation which feels like a bug to users, hence why I think this is to be considered a bug fix and not a feature, and also why I think it does not need to be optional at all: this is bug w.r.t. to vanilla, and the mod already hardcodes all keys w.r.t. to vanilla, so it does not change anything w.r.t. to the status quo that mod users / modpack authors should except when using the mod.

Of course it would be better to have full blown configurability, but that's IMO a different thing that should be tackled independently.

So this is out of scope currently and will not be merged in.

That is of course your call to make, I don't think I can add any more to the case than what I already stated, so please do close the PR if you still don't think it is not sensible 😉

[Jonny-Havoc]

This is hilarious, mutiple people are asking you to change this and you won't

I get continual bug reports from my players when the gods reject them from an item the can "legally" obtain from crypts

You should be allowed to use poison arrows just not craft them, you're literally deviating from vanilla progression

[nbusseneau]

@Jonny-Havoc I don't think using such a tone is productive... You can state your opinion without acting entitled. The mod author is ultimately the sole person that decides if something belongs to the mod or not, and we should always respect that.