Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support if-unused attribute in OsmChange. #78

Open
blackboxlogic opened this issue Jul 31, 2019 · 2 comments
Open

Support if-unused attribute in OsmChange. #78

blackboxlogic opened this issue Jul 31, 2019 · 2 comments
Assignees

Comments

@blackboxlogic
Copy link
Contributor

blackboxlogic commented Jul 31, 2019

I see there is a test to deserialize a a change file where the Delete element has an if-unused attribute, but

  • After deserialization, there is no record that the delete was 'if-unused'
  • There is no way to generate XML that has 'if-unused'

A description of the feature's purpose can be found here

@blackboxlogic blackboxlogic changed the title Change.Delete.If-Unused Support Change.Delete.If-Unused Jul 31, 2019
@blackboxlogic
Copy link
Contributor Author

There is no clear path for fixing this. If I got guidance, I can make a pull request. The problem is that Deletes are stored as an OsmGeo[] in OsmSharp.Changesets.OsmChange.Delete so there is no room for any more data on the Delete object. It could live on the OsmChange object though. Thoughts?

@xivk
Copy link
Contributor

xivk commented Aug 6, 2019

I'm assigning this to myself and have a look.

An idea: We could introduce an extra object specifically for delete operations that has an implicit cast from OsmGeo for the default cases.

@blackboxlogic blackboxlogic mentioned this issue Aug 29, 2019
@xivk xivk changed the title Support Change.Delete.If-Unused Support if-unused attribute in OsmChange. May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants