Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the eatRID method when RID is negative #70

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

ihortymoshenko
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.051% when pulling f2ab562 on IgorTimoshenko:hotfix/negative-rid into 7199226 on Ostico:master.

@Ostico
Copy link
Owner

Ostico commented Jun 29, 2016

Hi @IgorTimoshenko , i think that you have found some bug with 32bit PHP version on decoding RID because it is not possible to have a negative RID.
Can you provide some code to reproduce the issue and a test also?

@ihortymoshenko
Copy link
Contributor Author

@Ostico, negative RID is a temporary RID. In my case it appears in some select queries with the let keyword

@Ostico
Copy link
Owner

Ostico commented Jul 5, 2016

@IgorTimoshenko tnx, so i supppose this is a right behaviour, tnx for the PR, i will merge.

@Ostico Ostico merged commit 8a2b709 into Ostico:master Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants