Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

sonarqube: fix #250 #251

Merged
merged 1 commit into from
Feb 2, 2021
Merged

sonarqube: fix #250 #251

merged 1 commit into from
Feb 2, 2021

Conversation

tigran-a
Copy link
Contributor

@tigran-a tigran-a commented Feb 2, 2021

Restore plugin directory mount behaviour as in v9.2.6 and before, in case of no persistence enabled.

@rjkernick
Copy link
Contributor

This doesn't quite look like a rollback. File used to look like this: https://github.com/Oteemo/charts/pull/245/files

@tigran-a
Copy link
Contributor Author

tigran-a commented Feb 2, 2021

It is not a complete rollback. The problem happens now only when using no persistence. This patch uses the previous behaviour (mount extensions/downloads to an ephemeral volume) when no persistence is set, and a "new" one when the deployment is done with persistence (then we mount complete extensions directory, instead of its subdirectory).

@rjkernick rjkernick merged commit cbf94a8 into Oteemo:master Feb 2, 2021
@gvrf2911
Copy link
Contributor

This PR does not fix the case when we use both plugin installation by the HELM and persistence.

I think it is also the case of the people of the issue #255.

In my case, persistence is not used for plugins (and I don't have encounter the issue #245) but for ES data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants