Bugfix/add missing dependency specifications #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldrichter
approved these changes
Mar 25, 2021
mathiaseitz
reviewed
Mar 25, 2021
| "google-cloud-storage~=1.0" | ||
| "google-cloud-storage~=1.0", | ||
| "urllib3~=1.25", | ||
| "packaging~=20.0" |
There was a problem hiding this comment.
Why do we require this as an explicit runtime dependency?
There was a problem hiding this comment.
Because it is needed during runtime for version checking of the urllib3 dependency. More specifically we use the parse_version function from packaging.
These are the core packaging utilities for python packages and it is maintained by the Python Packaging Authority...
trendelkampschroer
deleted the
bugfix/add_missing_dependency_specifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.