Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added USB connectivity setting #71

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Added USB connectivity setting #71

merged 4 commits into from
Dec 20, 2020

Conversation

gitaroktato
Copy link
Contributor

Added USB connectivity setting necessary for some of the Linux distribution mentioned in #38 (comment)

@gitaroktato
Added USB connectivity setting
637618c 
Added USB connectivity setting necessary for some of the Linux distribution mentioned in OttoDIY#38 (comment)
@gitaroktato gitaroktato mentioned this pull request Dec 16, 2020
Merged
@cparrapa
Copy link
Member

I don't have a Linux at hand to test but i guess all good thanks! @gitaroktato

mxochicale
mxochicale requested changes Dec 17, 2020
View reviewed changes
Copy link

@mxochicale mxochicale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gitaroktato nice you pointed out the group permission. I added two comments, hope they make sense and then I guess it is ready to be merge.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gitaroktato
Copy link
Contributor Author

Hi @gitaroktato nice you pointed out the group permission. I added two comments, hope they make sense and then I guess it is ready to be merge.

@mxochicale thanks for the feedback. I updated my changes accordingly. Could you please take a look?

mxochicale
mxochicale requested changes Dec 17, 2020
View reviewed changes
Copy link

@mxochicale mxochicale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice amend, just added another comment!

README.md Show resolved Hide resolved
@gitaroktato
Updated README.md and added reference link.
05e9921
@gitaroktato
Updated link for USB connectivity
a55d51c 
Updated link for USB connectivity to point to the specific StackOverflow answer.
@mxochicale
Copy link

Thanks @gitaroktato for your nice changes!

@cparrapa This PR looks good to me! so if you are happy with it, you can merge it!

@cparrapa cparrapa removed the request for review from agomezgar December 18, 2020 19:15
@cparrapa
Copy link
Member

Looks good to me too but github shows you still requested a change from the review @mxochicale
image

@mxochicale
Copy link

Thanks @cparrapa , just clicked approved! also thanks to @gitaroktato for your great input!

@cparrapa cparrapa merged commit 63d50fb into OttoDIY:versionlinux Dec 20, 2020
@cparrapa
Copy link
Member

Thanks @gitaroktato and @mxochicale this version is looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxochicale mxochicale mxochicale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitaroktato @cparrapa @mxochicale